openforce/tests/custom_objects/test_field_constraints.py

126 lines
4.6 KiB
Python

"""
Targeted tests for CustomFieldDefinition.clean() and CustomRecord.clean()
covering the lines (96-102, 105, 126-131) that were below threshold after Phase 1.
"""
import pytest
from django.contrib.auth import get_user_model
from django.core.exceptions import ValidationError
from custom_objects.models import CustomObjectDefinition, CustomFieldDefinition, CustomRecord
User = get_user_model()
@pytest.fixture
def user(db):
return User.objects.create_user(username="testuser", password="pass")
@pytest.fixture
def custom_object(db):
obj = CustomObjectDefinition(name="Project__c", label="Project", plural_label="Projects")
obj.save()
return obj
class TestCustomFieldDefinitionClean:
"""Lines 96-102, 105 — CustomFieldDefinition.clean()"""
def test_name_auto_suffixed_with_c(self, db, custom_object):
"""Name without __c suffix should be auto-suffixed on clean()."""
field = CustomFieldDefinition(
custom_object=custom_object,
name="budget", # no __c
field_type="number",
label="Budget",
)
field.full_clean()
assert field.name == "budget__c"
def test_name_already_suffixed_not_doubled(self, db, custom_object):
"""Name already ending in __c must not get a second __c appended."""
field = CustomFieldDefinition(
custom_object=custom_object,
name="budget__c",
field_type="number",
label="Budget",
)
field.full_clean()
assert field.name == "budget__c"
def test_select_field_without_choices_raises(self, db, custom_object):
"""select field_type with no choices must raise ValidationError."""
field = CustomFieldDefinition(
custom_object=custom_object,
name="status__c",
field_type="select",
label="Status",
choices=None,
)
with pytest.raises(ValidationError) as exc_info:
field.full_clean()
assert "choices" in str(exc_info.value)
def test_select_field_with_choices_passes(self, db, custom_object):
"""select field_type with choices provided must not raise."""
field = CustomFieldDefinition(
custom_object=custom_object,
name="status__c",
field_type="select",
label="Status",
choices=["Open", "Closed"],
)
field.full_clean() # should not raise
def test_lookup_field_without_target_raises(self, db, custom_object):
"""lookup field_type without target_object must raise ValidationError."""
field = CustomFieldDefinition(
custom_object=custom_object,
name="related__c",
field_type="lookup",
label="Related",
target_object=None,
)
with pytest.raises(ValidationError) as exc_info:
field.full_clean()
assert "target_object" in str(exc_info.value)
def test_lookup_field_with_target_passes(self, db, custom_object):
"""lookup field_type with target_object (FK instance) must not raise."""
# Create a second custom object to use as target
target = CustomObjectDefinition.objects.create(name="Account__c", label="Account")
field = CustomFieldDefinition(
custom_object=custom_object,
name="related__c",
field_type="lookup",
label="Related",
target_object=target,
)
field.full_clean() # should not raise
class TestCustomRecordClean:
"""Lines 126-131 — CustomRecord.clean() delegates to schema_engine."""
def test_record_with_valid_data_passes_clean(self, db, custom_object, user):
"""Verifies that with blank=True, a CustomRecord with empty dict data passes full_clean()."""
record = CustomRecord(custom_object=custom_object, data={}, owner=user)
record.full_clean() # should not raise
assert record.data == {}
def test_record_with_required_field_missing_raises(self, db, custom_object, user):
"""A record missing a required field should raise ValidationError from clean()."""
# Add a required text field
field = CustomFieldDefinition.objects.create(
custom_object=custom_object,
name="title__c",
field_type="text",
label="Title",
is_required=True,
choices=None,
target_object=None,
)
record = CustomRecord(custom_object=custom_object, data={}, owner=user)
with pytest.raises((ValidationError, Exception)):
# schema_engine will raise because required field is missing
record.full_clean()